Last modified: 2013-04-22 16:14:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43854, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41854 - Cache expensive elements in Special:TimedMediaHandler
Cache expensive elements in Special:TimedMediaHandler
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Jan Gerber
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-07 17:17 UTC by Rob Lanphier
Modified: 2013-04-22 16:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Lanphier 2012-11-07 17:17:57 UTC
Currently, the performance of Special:TimedMediaHandler is apparently bad enough that we need to severely restrict who has access to it.  We need to instead cache it well enough so that it can be available to anonymous users.
Comment 1 Sam Reed (reedy) 2012-11-07 17:23:02 UTC
Line 155 onwards in SpecialTimedMediaHandler:

'img_media_type = "VIDEO" AND (' . $condition . ')',

img_media_type isn't currently indexed in core (maybe it should be?)

Also, $condition may also not be, depending on it's contents
Comment 2 Sam Reed (reedy) 2012-11-07 17:25:02 UTC
array( 'transcode_key' => $key ),

transcode_key from the transcode table isn't indexed  (well, it is, as a second column, but if we're not using that one, it doesn't help)

That one can/should be trivially fixed by adding an extra index on it.

Table should be small enough to add the index straight off
Comment 3 Sam Reed (reedy) 2012-11-07 17:34:15 UTC
(In reply to comment #2)
> array( 'transcode_key' => $key ),
> 
> transcode_key from the transcode table isn't indexed  (well, it is, as a second
> column, but if we're not using that one, it doesn't help)
> 
> That one can/should be trivially fixed by adding an extra index on it.
> 
> Table should be small enough to add the index straight off

https://gerrit.wikimedia.org/r/32236
Comment 4 db [inactive,noenotif] 2012-11-18 13:33:31 UTC
(In reply to comment #3)
> https://gerrit.wikimedia.org/r/32236

Status Merged
Comment 5 Sam Reed (reedy) 2012-11-18 15:02:07 UTC
I'm not sure this is actually fixed yet. I just addressed one issue
Comment 6 Jan Gerber 2012-12-05 11:43:49 UTC
https://gerrit.wikimedia.org/r/#/c/35140/ should fix this bug, reviews welcome.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links