Last modified: 2012-11-09 00:58:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43862, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41862 - CentralNotice Allocations may underallocate midsequence slots
CentralNotice Allocations may underallocate midsequence slots
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: High critical (vote)
: ---
Assigned To: Matt Walker
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-07 20:27 UTC by Matt Walker
Modified: 2012-11-09 00:58 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matt Walker 2012-11-07 20:27:29 UTC 
WMDE reported a situation where allocations were not as they expected in a 5 banner equal weighted campaign. Quantitatively they obtained (0.23, 0.20, 0.17, 0.20, 0.20) over 3,546,000 impressions.

A test on AA wiki shows agrees with this result, the number of slots allocated, in same banner order, was (7, 6, 5, 6, 6).

The 7 slot banner was in slots 24 thru 30.
The 5 slot banner was in slots 13 thru 17.
Comment 1 Matt Walker 2012-11-07 21:06:17 UTC 
The bug comes in at BannerChooser.php:chooseBanner(). 1/5 + 1/5 + 1/5 in double precision floating point comes to just infinitesimally above the slot boundary under allocating this banner. This error is then corrected by the final slot.
Comment 2 Matt Walker 2012-11-07 23:09:25 UTC 
The patch for this bug is https://gerrit.wikimedia.org/r/#/c/32317/
Comment 3 Matt Walker 2012-11-07 23:22:56 UTC 
Deploy window scheduled for UTC Nov 8 2300.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links