Last modified: 2012-12-25 21:49:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43866, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41866 - Notifications from no-longer-enabled extensions which use custom formatters cause errors
Notifications from no-longer-enabled extensions which use custom formatters c...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: bsitu
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-07 22:05 UTC by Ryan Kaldari
Modified: 2012-12-25 21:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2012-11-07 22:05:07 UTC
For example, the PageTriage extension creates 'reviewed' notices and specifies their format. If you turn off PageTriage, all of its notices are still listed in your Notifications flyout, but they are all broken due to the missing formatter.

Perhaps notifications that are missing formatters should just not be shown at all.
Comment 1 Alex Monk 2012-11-10 18:22:06 UTC
Also, the error that we do have:
* Overlaps with text, like notifications did with each other in bug 41968.
* Is actually a missing message.
Comment 2 Alex Monk 2012-11-10 18:58:09 UTC
(In reply to comment #1)
> * Is actually a missing message.

Oops. This was fixed in Gerrit change #15959. Though it could probably use $1, the event type.
Comment 4 db [inactive,noenotif] 2012-12-10 20:17:44 UTC
(In reply to comment #3)
> https://gerrit.wikimedia.org/r/#/c/33290/

Status Merged
Comment 5 Alex Monk 2012-12-25 21:49:51 UTC
(In reply to comment #3)
> https://gerrit.wikimedia.org/r/#/c/33290/

Merged by Kaldari on the 3rd.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links