Last modified: 2012-12-21 20:44:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43869, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41869 - ".mw-hiero-table td { vertical-align: middle; }" is overridden when embedded in other tables.
".mw-hiero-table td { vertical-align: middle; }" is overridden when embedded ...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiHiero (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-07 22:43 UTC by Erwin Dokter
Modified: 2012-12-21 20:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erwin Dokter 2012-11-07 22:43:54 UTC
The rule that ensures vertical centering:

.mw-hiero-table td {
    vertical-align: middle;
}

...is overridden when hieros are embedded in another table, such as infobox, which have their own vertical-align set. This is because rules set in Common.css override those in extension CSS (by being loaded later. A simple fix is to add specificallity, thus the rule should be changed to:

table.mw-hiero-table td {
    vertical-align: middle;
}

This ensures that blanket CSS rules (classes not attached to elements) do not override the extensions' CSS.
Comment 1 Andre Klapper 2012-11-10 17:18:13 UTC
Not sure how actively WikiHiero is maintained. 
CC'ing its developer Guillaume, clarification welcome.
Comment 2 Guillaume 2012-11-10 20:51:45 UTC
Hi,
I'm not maintaining WikiHiero since some years (I was working on new hieroglyph system).
The CSS rule change seem OK for me. If anybody can commit it, it would be nice.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links