Last modified: 2012-11-09 16:10:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43883, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41883 - # in link when using TMH
# in link when using TMH
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-08 11:39 UTC by Derk-Jan Hartman
Modified: 2012-11-09 16:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2012-11-08 11:39:33 UTC
When clicking the radio buttons to switch players, it seems no e.preventDefault() is present in the click handler and the # (of the <a href) is added to the URL of the page.

e.preventDefault should be used in the click handler.
Comment 1 Michael Dale 2012-11-09 06:13:03 UTC
https://gerrit.wikimedia.org/r/32497

We generally return false, so I did it that way to be consistent.
Comment 2 Alex Monk 2012-11-09 16:10:49 UTC
Merged by J, I assume this is fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links