Last modified: 2012-11-12 14:58:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43937, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41937 - 1.21wmf3 causes loading problems with IE in compatibility mode: exception for mw.centralNotice.initialize()
1.21wmf3 causes loading problems with IE in compatibility mode: exception for...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matt Walker
: code-update-regression
: 41750 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-09 23:15 UTC by kipod
Modified: 2012-11-12 14:58 UTC (History)
10 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description kipod 2012-11-09 23:15:50 UTC
problem observed on enwiki and hewiki. probably exists elsewhere.

REPRODUCTION:
============

* in internet explorer 8 or 9, use Tools => Internet Options => Advance, and mark the checkbox "Display notification on every script error".
* Activate "Compatilbility mode"
* Open main page in hewiki or enwiki


WHAT WILL YOU SEE
=================

* you get an exception on call to mw.centralNotice.initialize() (mw.centralNotice is null at the time this code executes)
* you will get consecutive exceptions that depend on which wiki is it
* if you log in to your account, many of your preferences will not be respected. e.g., if you enabled the "navpop" (aka "popup") gadget on enwiki, it will fail to work.

peace.
Comment 1 kipod 2012-11-09 23:34:53 UTC
(addition): tested some more wikis: es, nl, de, ar, fa, pt - first exception (centralNotice) is same on all those wikis. 
continuation varies depending on wiki, but each of those had at least one exception.

tentative diagnosis: for all sane browsers, mediawiki.util is loaded before site-specific common.js. 
for some perverted reason, not so for IE in compatibility mode.

(this pertains to the other exceptions - i have no idea where centralNotice is supposed to be initialized).

peace.
Comment 2 Matt Walker 2012-11-10 00:38:28 UTC
Patch submitted - https://gerrit.wikimedia.org/r/32673
Comment 3 Matt Walker 2012-11-10 00:47:51 UTC
Kipod: thanks for the report! Hopefully the above patch will fix things. A couple of things were happening that shouldn't have been.

I've removed the dependency on mw.util (it didn't need it). This in and of itself should solve the issue. If it doesn't I've also modified the CentralNotice skin hook to explicitly depend on the CN module. However, this skin change will take some time to propogate through the system (ie: it will only take effect on the page when the page is purged/edited.)
Comment 4 Matt Walker 2012-11-10 01:46:45 UTC
*** Bug 41750 has been marked as a duplicate of this bug. ***
Comment 5 Andre Klapper 2012-11-12 11:33:49 UTC
Patch has been merged => can this be closed as RESOLVED FIXED?
Comment 6 Derk-Jan Hartman 2012-11-12 14:30:42 UTC
@Andre, this really also needs to be deployed asap. I think we can close it then.
Comment 7 Sam Reed (reedy) 2012-11-12 14:58:45 UTC
Done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links