Last modified: 2013-04-22 16:16:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44036, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42036 - Account creation by email uses a protocol-relative URL for the wiki
Account creation by email uses a protocol-relative URL for the wiki
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-12 04:20 UTC by Isarra
Modified: 2013-04-22 16:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Isarra 2012-11-12 04:20:08 UTC
Unlike in other MediaWiki emails, creating an account by email and sending the new user a password that way results in the user also being sent only a protocol-relative url:

Someone created an account for your e-mail address on OTRS Wiki (<//otrs-wiki.wikimedia.org/w/index.php>) named "Isarra"...

There should be a http: in it like the urls in other emails have.
Comment 1 Daniel Friesen 2012-11-12 04:38:13 UTC
Line 875 of SpecialUserlogin inside SpecialUserlogin::mailPasswordInternal.

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/specials/SpecialUserlogin.php;hb=HEAD#l875

Looks like $wgServer and $wgScript are used directly instead of using helper methods and using wfExpandUrl along with PROTO_CANONICAL.
Comment 2 Brad Jorsch 2012-11-12 05:00:44 UTC
Or we could just use $wgCanonicalServer.

Gerrit change #33048
Comment 3 Daniel Friesen 2012-11-12 05:56:37 UTC
No need to continue using global cruft when we have better interfaces for such things. Anything manually concatenating a $wg*Server with a path is way out of date.
Comment 4 Brad Jorsch 2012-11-12 06:07:36 UTC
I look forward to your changeset that cleans up the use of $wg*Server, $wgScript*, and so on throughout the whole codebase.
Comment 5 Alexandre Emsenhuber [IAlex] 2012-11-12 06:40:52 UTC
Change merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links