Last modified: 2012-11-18 12:52:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44043, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42043 - LotteryOdds incorrect calculation
LotteryOdds incorrect calculation
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-12 12:38 UTC by se4598
Modified: 2012-11-18 12:52 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description se4598 2012-11-12 12:38:56 UTC
File: /modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.verify.js
Line 203

If a article is a lottery-article is incorrect calculated:
Currently for odds=100 articles with e.g. curid=1000 still not included.

Proposed fix 1: return ( Number( article.id ) % 1000 ) > ( 999 - ( Number( odds ) * 10 ) );
Proposed fix 2: return ( Number( article.id ) % 1000 ) >= ( 1000 - ( Number( odds ) * 10 ) );
Comment 1 Matthias Mullie 2012-11-12 12:43:59 UTC
Nice catch. Patch in Gerrit: https://gerrit.wikimedia.org/r/#/c/33069/
Comment 2 db [inactive,noenotif] 2012-11-18 12:52:41 UTC
Status Merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links