Last modified: 2013-01-08 11:01:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44098, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42098 - iframe embeds should allow fullscreen
iframe embeds should allow fullscreen
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 11:51 UTC by Jan Gerber
Modified: 2013-01-08 11:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jan Gerber 2012-11-14 11:51:16 UTC
right now fullscreen does not work if video is embedded as an iframe.

As a first step the embed dialog should add allowfullscreen to the iframe

inside the iframe something like this should be used:
if(window.frameElement && window.frameElement.hasAttribute("allowFullScreen")){
  ...
}
Comment 1 Jan Gerber 2012-12-31 10:49:36 UTC
working patch at https://gerrit.wikimedia.org/r/#/c/33339/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links