Last modified: 2012-11-29 14:59:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44101, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42101 - Removed alias gets displayed again when adding a new one
Removed alias gets displayed again when adding a new one
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on: 42262
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 14:41 UTC by tobias.gritschacher
Modified: 2012-11-29 14:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2012-11-14 14:41:30 UTC
We have "Zombie"-Aliases:

* Add an alias "zombie"
* Click "save"
* Remove the "zombie" alias
* Click "save"
* Add another alias, e.g. "12345"
* Click "save"
* Now the "zombie" alias appears again
Comment 1 Daniel Kinzler 2012-11-19 12:56:16 UTC
Consider that you are always editing the *base* revision - the revision that was current when you loaded the page. So: when you remove the "Zombie" alias, you are removing it from the original revision, which doesn't even have it. This generates an empty patch to be applied to the current/latest revision. So it isn't removed. 

I don't see a solution other than maintaining the base revision for every widget, or trying to detect edit conflicts based on the field's previous value instead of using the base revision at all. That could actually be nice, but would need more work. OPen a ticket for that?
Comment 2 tobias.gritschacher 2012-11-19 13:16:01 UTC
I think tracking the baserevid for each widget would be the easiest solution. I
made a new ticket for that: bug 42262
Comment 3 Aude 2012-11-19 13:46:54 UTC
Also fails:

1) add site link enwiki => Map (all good so far)
2) add site link eswiki => Mapa (good so far)
3) click edit => remove of enwiki site link and get an error "The site link could not be removed."

If I reload the page, I can remove the enwiki site link.
Comment 4 Daniel Kinzler 2012-11-19 13:51:18 UTC
yes, in step 3, you are trying to remove the sitelink from the base revision, which does not contain it.
Comment 5 Anja Jentzsch 2012-11-22 15:04:20 UTC
Selenium test for this bug: https://gerrit.wikimedia.org/r/#/c/33346/
Comment 6 tobias.gritschacher 2012-11-23 16:24:35 UTC
this will be solved by
https://gerrit.wikimedia.org/r/#/c/34723/
https://gerrit.wikimedia.org/r/#/c/34880/
Comment 7 abraham.taherivand 2012-11-29 14:59:12 UTC
Verified in Wikidata demo time for sprint 24

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links