Last modified: 2013-04-22 16:14:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44109, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42109 - Braces in attributes break
Braces in attributes break
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-14 20:06 UTC by Roan Kattouw
Modified: 2013-04-22 16:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2012-11-14 20:06:20 UTC 
Example input:

#<p data-ve-changed="{&quot;created&quot;:1,&quot;content&quot;:35,&quot;rebuilt&quot;:1}">The first thing, followed by...</p>

Expected output: <li><p data-ve-changed="{...}">Text</p></li>
Observed output: <li>&lt;p data-ve-changed=&quot;{...}&quot;&gt;Text&lt;/p&gt;</li>

Round-tripping is also broken, but the bigger issue is that the HTML tag renders as plain text.
Comment 1 Gabriel Wicke 2012-11-14 20:10:19 UTC 
Minimal test case:

<p foo="{}">

Need to relax syntactical breaks to allow single braces in attributes.
Comment 2 Gabriel Wicke 2012-12-10 19:14:04 UTC 
Patch pushed in https://gerrit.wikimedia.org/r/#/c/37862/.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links