Last modified: 2012-12-04 10:44:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44116, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42116 - After MediaWiki 1.20 upgrade WikiEditor extension not working with Vector skin
After MediaWiki 1.20 upgrade WikiEditor extension not working with Vector skin
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
REL1_20-branch
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 23:55 UTC by jb.holcroft
Modified: 2012-12-04 10:44 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jb.holcroft 2012-11-14 23:55:21 UTC
On two different wikis, wikieditor doesn't work anymore with Vector.
There is no toolbar or anything related to the extension common content.

It works fine with Monobook or other styles.

Others looks like to have the same issue :
https://www.mediawiki.org/wiki/Extension_talk:WikiEditor#Playing_Badly_with_Vector_in_1.20

My previous configuration where :

$wgDefaultUserOptions['usebetatoolbar'] = 1;
$wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;
$wgDefaultUserOptions['wikieditor-preview'] = 1;


I tried with the configuration on the mediawiki.org but it doesn't help :

# Enables use of WikiEditor by default but still allow users to disable it in preferences
$wgDefaultUserOptions['usebetatoolbar'] = 1;
$wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;
# Displays the Preview and Changes tabs
$wgDefaultUserOptions['wikieditor-preview'] = 1;
# Displays the Publish and Cancel buttons on the top right side
$wgDefaultUserOptions['wikieditor-publish'] = 1;
# Displays a navigation column (summary) on the right side
$wgDefaultUserOptions['usenavigabletoc'] = 1;


Is an option missing to make it work ?

Thank you very much
Comment 1 Andre Klapper 2012-11-15 08:47:19 UTC
Which browsers and browser versions was this tested with?
Comment 2 jb.holcroft 2012-11-15 09:25:24 UTC
I did try with :
- Firefox 16 (Linux & Windows 7)
- Gnome Web 3.4.3 (Webkit based)
- Chrome 21 Linux
- Chrome 23 Windows

I can't try with IE.
Comment 3 jb.holcroft 2012-11-15 09:28:34 UTC
I forgot to add : I updated yesterday WikiEditor and Vector to latest git version.
Comment 4 jb.holcroft 2012-11-16 09:24:45 UTC
You can use this wiki to see the bug :
http://bug.wikoutils.org/w/index.php?title=Bug_demo&action=edit
Comment 5 Michael M. 2012-11-16 09:47:13 UTC
(In reply to comment #3)
> I forgot to add : I updated yesterday WikiEditor and Vector to latest git
> version.

Sure? Your Vector extension still contains reference to mediawiki.legacy.mwsuggest (e.g. in http://bug.wikoutils.org/w/extensions/Vector/modules/ext.vector.simpleSearch.js), which was removed recently by Gerrit change #24680.
Comment 6 jb.holcroft 2012-11-16 10:29:45 UTC
In fact I don't know, since you are using Git and rolling release (every two weeks), it is very difficult to know what to extract to upgrade a mw based site.

I use this simple script (homemade) to extract extensions :
https://www.mediawiki.org/wiki/User:Jibec/git-script.sh

If i search branches in my Vector git folder I got :
[Vector]$ git branch -r | sort -V
  origin/HEAD -> origin/master
  origin/REL1_20
  origin/master
  origin/wmf/1.20wmf11

So I assume (git is not obvious to me) my script extract everything that is in origin/REL1_20 if the tag exist, if not, it extract master.

Is your change also into REL1_20 ?
Comment 7 jb.holcroft 2012-11-16 21:44:58 UTC
You were right, it was related to the way to extract datas from git.

I corrected my script :

https://www.mediawiki.org/w/index.php?title=User%3AJibec%2Fgit-script.sh&diff=606296&oldid=606119

If it is possible, please give a little love to #16424

Thank you

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links