Last modified: 2013-04-04 00:45:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44117, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42117 - VisualEditor: Replaced Edit tab should use original label instead of fetching message "edit" msg
VisualEditor: Replaced Edit tab should use original label instead of fetching...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2013-04-15
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 23:57 UTC by Roan Kattouw
Modified: 2013-04-04 00:45 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2012-11-14 23:57:04 UTC
When loading a page with VE enabled, the "edit" tab is changed from the "vector-view-edit" message to the "edit" message. This is apparent on enwiki, where these messages have different values. It's also apparent when using ?uselang=qqx

This shouldn't happen, the message for the edit tab should be consistent.
Comment 1 James Forrester 2012-11-15 22:12:45 UTC
Problem is in ViewPageTarget, which assumes that the name of the action and the action's label are the same ('edit' or 'create') or something, per hurried conversation with Trevor. :-)

More widely, we might want our own label for this at first anyway to make it clear which editor people are using during the initial integration - just call it "VisualEditor" and leave the other tab visible next to it?
Comment 2 James Forrester 2012-11-17 03:27:46 UTC
De-prioritising for December; instead, bug 42221 will take on this need, as discussed with Trevor and Roan.
Comment 3 Krinkle 2013-04-03 22:17:36 UTC
Change-Id: I2e7dd85cd14049101e2d49751d37797d77bc7c9d
Comment 4 Krinkle 2013-04-03 22:20:41 UTC
Rephrased summary.

The problem is that different skins use a different message for the Edit button. Vector uses msg key "vector-view-edit". Monobook (and most other skins) use msg key "edit".

By default the messages are equal but on en.wikipedia.org, as example, classic msg "edit" has been changed to contain "Edit this page".

This lead to the tab replacement causing a weird change from "Edit" to "Edit this page" when in VE mode.
Comment 5 James Forrester 2013-04-04 00:45:28 UTC
Now merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links