Last modified: 2012-11-26 17:28:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44121, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 42121 - VisualEditor: Paragraph generated for an empty document should not be unwrapped on the way out


Summary:	VisualEditor: Paragraph generated for an empty document should not be unwrapp...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Data Model (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2012-11-26
Assigned To:	Roan Kattouw

URL:
Whiteboard:
Keywords:

Duplicates:	41905 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-11-15 00:22 UTC by Roan Kattouw
Modified:	2012-11-26 17:28 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2012-11-15 00:22:10 UTC

Currently, the DOM->data converter generates an empty paragraph if the input is an empty string. This paragraph is marked with .internal.generated=='wrapper', so it's unwrapped on the way out. This is bad because we lose change markers that way, and have no way to propagate them.

Instead, it should use another generated marker which causes the paragraph to be unwrapped only if it is empty, and be preserved if it's not empty.

Comment 1 Roan Kattouw 2012-11-17 03:42:41 UTC

https://gerrit.wikimedia.org/r/33854

Comment 2 James Forrester 2012-11-17 06:32:57 UTC

*** Bug 41905 has been marked as a duplicate of this bug. ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links