Last modified: 2012-11-15 11:29:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44143, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42143 - UploadWizard broken in Safari 5
UploadWizard broken in Safari 5
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-15 06:33 UTC by Erik Moeller
Modified: 2012-11-15 11:29 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Moeller 2012-11-15 06:33:33 UTC
For both multi- and single-file uploads, UploadWizard gets stuck on "Getting file information and previews" on the first step. This was reported on https://commons.wikimedia.org/wiki/Commons:Village_pump and I was able to reproduce it with a VM. I did not see any errors in a Firebug Lite console.
Comment 1 Rob Lanphier 2012-11-15 07:20:19 UTC
Due to the timing reported on Commons, this seems quite likely to be a 1.21wmf4 issue (deployed earlier today).  A few possible culprits here:
https://www.mediawiki.org/wiki/MediaWiki_1.21/wmf4#UploadWizard
Comment 2 Ryan Kaldari 2012-11-15 09:54:25 UTC
Probably would be best for us to revert UploadWizard on Commons for now and then debug on a different server. The Flickr support included a lot of significant changes, so it may take some work to track down. I know that Safari is especially restrictive about iframes (which UploadWizard relies on), so that would be one area to investigate. I'll see about doing an un-deploy in the morning. Nischay, if you want to try doing some debugging in the meantime, that would be helpful as well.
Comment 3 Ryan Kaldari 2012-11-15 10:07:43 UTC
I get the following 2 JS errors in Safari:

mw.UploadWizardUploadInterface.js line 335:
TypeError: 'undefined' is not an object (evaluating 'this.upload.file.size')

mw.UploadWizardDetails.js line 1002:
TypeError: 'undefined' is not an object (evaluating 'this.upload.file.description')

The first one is most likely related to the change at the bottom here:
https://gerrit.wikimedia.org/r/#/c/12269/26/resources/mw.UploadWizardUploadInterface.js
Comment 4 Ryan Kaldari 2012-11-15 10:11:01 UTC
I'm going to try a quick fix...
Comment 5 Ryan Kaldari 2012-11-15 10:51:25 UTC
OK, it's fixed and the fix is live on Commons. Verified that I was able to successfully upload a file via Safari 5. Now I should get some sleep :)
Comment 6 Ryan Kaldari 2012-11-15 10:59:22 UTC
Grr.. My Safari fix broke it in Firefox :(
Comment 7 Ryan Kaldari 2012-11-15 11:05:27 UTC
I rolled back the fix for Safari. Stay tuned...
Comment 8 Ryan Kaldari 2012-11-15 11:29:28 UTC
OK, fixed for Safari and Firefox, deployed, and verified in both.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links