Last modified: 2013-07-30 01:11:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44245, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42245 - database connection is inconsistent
database connection is inconsistent
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Matt Walker
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-18 17:48 UTC by Adam Wight
Modified: 2013-07-30 01:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Adam Wight 2012-11-18 17:48:48 UTC
Honestly, I could not wrap my head around commit a14e49e523fd29d9294ff8e31817ab56df333012, "Make $wgCentralDBname default to false".  While poking around to understand the issue, I noticed that CentralNotice.db.php is sometimes getting a database connection using this string, and at other times using the primary database name.

This patch introduces a helper function to get the database connection in a consistent manner.  It's possible that I misunderstand something basic about why we were using two databases.

https://gerrit.wikimedia.org/r/33986
Comment 1 Andre Klapper 2013-07-23 09:13:45 UTC
Patch got abandoned and needs rework.
Comment 2 Gerrit Notification Bot 2013-07-30 00:44:24 UTC
Change 76669 had a related patch set uploaded by Mwalker:
Unify CentralNotice database creation

https://gerrit.wikimedia.org/r/76669
Comment 3 Gerrit Notification Bot 2013-07-30 00:56:29 UTC
Change 76669 merged by Adamw:
Unify CentralNotice database creation

https://gerrit.wikimedia.org/r/76669

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links