Last modified: 2012-11-26 23:32:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44278, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42278 - VisualEditor: After clicking out of link inspector, pressing enter removes wrong text
VisualEditor: After clicking out of link inspector, pressing enter removes wr...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2012-11-26
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-20 02:29 UTC by Roan Kattouw
Modified: 2012-11-26 23:32 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2012-11-20 02:29:20 UTC
1. Type the text "Foo bar baz"
2. Select "bar"
3. Click the link toolbar button
4. Click between the a and the z ("ba|z") to cause the inspector to close
5. Press enter

Expected result: paragraph is split with "z" in a new paragraph
Actual result: "bar" is removed, paragraph is split with "baz" in a new paragraph

Occurs in both Firefox and Chrome. Isn't reproducible 100% of the time.

Theory:
1. User changes selection to ba|z
2. SurfaceObserver notices and adjusts its selection
3. Link inspector notices and triggers annotation on a fragment with a different range (the link)
4. Some bug in SurfaceObserver or SurfaceFragment causes SO to believe the current selection is now the link
5. User presses enter, SO removes what it believes is the selection
Comment 1 Trevor Parscal 2012-11-26 23:14:57 UTC
Fixed in recent inspector rewrite: I38995d4101fda71bfb2e6fe516603507ce820937 and Ibf6b26de299e54ae8688a2653bf5d5538927f8c3

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links