Last modified: 2012-11-26 17:28:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44279, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42279 - VisualEditor: Pre-annotations code annotates characters with the empty set
VisualEditor: Pre-annotations code annotates characters with the empty set
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2012-11-26
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-20 02:34 UTC by Roan Kattouw
Modified: 2012-11-26 17:28 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2012-11-20 02:34:03 UTC 
1. Open any document
2. Blank it
3. Type some text
4. Dump the model into the console (ve.instances[0].documentModel.data)

Expected output: [ 'F', 'o', 'o', 'b', 'a', 'r' ]
Actual output: [ 'F', ['o', ve.AnnotationSet([])], ['b', ve.AnnotationSet([])] ...

The pre-annotations code is applying the empty set as a pre-annotation to every character except the first. This shouldn't happen, it should just not annotate if it's got nothing to annotate with.
Comment 1 Roan Kattouw 2012-11-21 20:40:21 UTC 
Trevor has a commit queued up that fixes this.
Comment 2 Roan Kattouw 2012-11-21 23:43:36 UTC 
https://gerrit.wikimedia.org/r/#/c/34598/
Comment 3 Roan Kattouw 2012-11-22 00:21:03 UTC 
...doesn't actually fix it, will investigate.
Comment 4 Roan Kattouw 2012-11-22 01:07:18 UTC 
Actually fixed in Gerrit change #34684
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links