Last modified: 2012-12-07 23:10:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44298, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42298 - VisualEditor: Handle percent-encoding in MWInternalLinkAnnotation
VisualEditor: Handle percent-encoding in MWInternalLinkAnnotation
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2012-12-10
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-20 20:03 UTC by Roan Kattouw
Modified: 2012-12-07 23:10 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2012-11-20 20:03:06 UTC 
Per conversation with Gabriel, MWInternalLinkAnnotation needs to deal with percent-encoded hrefs. At least question marks (?) and percent signs (%) will be encoded. We need to decode these before presenting them to the user, encode the user input on the way out, and use href shadowing to make sure we don't change the href if the user didn't change the target (even if that would otherwise happen due to complete vs partial percent-encoding).
Comment 1 Trevor Parscal 2012-12-07 20:36:25 UTC 
If5d22e88904d6b2c438caac403ac2d78d440b017 resolves this issue. It's still dependent on bug 41116 (which has a patch that needs merging: I5e1de9244d727641c10b6f0a89acc61afba7ecad )
Comment 2 Gabriel Wicke 2012-12-07 21:45:43 UTC 
I5e1de9244d727641c10b6f0a89acc61afba7ecad will not actually fix the problem. I'm cleaning up our link serialization handler right now, which should also fix this issue.
Comment 3 Trevor Parscal 2012-12-07 23:10:07 UTC 
It's resolved on our end, we have bug 41116 to track the other issues.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links