Last modified: 2013-07-17 14:22:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44358, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42358 - The create item link in Special:ItemDisambiguation
The create item link in Special:ItemDisambiguation
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-22 13:25 UTC by jeblad
Modified: 2013-07-17 14:22 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description jeblad 2012-11-22 13:25:35 UTC 
Something strange is going on here. This is fixed in really old changes. See for example
Change I36e6abf5: (Bug 39485) Encode params for ItemByLabel and ItemByTitle

Also there are old bugs about this; Bug 39485 - Add item link is broken on Special:ItemByTitle, Bug 42149 - Broken link in the invitation for users to update the item
Comment 1 denny vrandecic 2012-12-06 12:59:05 UTC 
Looks good to me, cannot reproduce. Is this still the case? (if so, set status back to NEW)
Comment 2 Matthew Flaschen 2013-03-31 20:24:11 UTC 
Yes, it is happening in production right now:

https://www.wikidata.org/wiki/Special:ItemDisambiguation/en/train_line

ItemByLabel is now called ItemDisambiguation.  You can see that both the link and visible text are broken.

And the message is straight from code: https://www.wikidata.org/w/index.php?title=Special%3AAllMessages&prefix=Wikibase-itemdisambiguation-create&filter=unmodified&lang=en&limit=50

That fix looks correct.  Looking at the code, it seems to have been lost in a merge somewhere along the way.
Comment 3 Gerrit Notification Bot 2013-07-03 07:58:12 UTC 
Change 71763 had a related patch set uploaded by Aude:
(bug 42358) url encode label in item disambiguation create item link

https://gerrit.wikimedia.org/r/71763
Comment 4 Gerrit Notification Bot 2013-07-03 13:18:57 UTC 
Change 71763 merged by jenkins-bot:
(bug 42358) url encode label in item disambiguation create item link

https://gerrit.wikimedia.org/r/71763
Comment 5 abraham.taherivand 2013-07-17 14:22:26 UTC 
Verified in Wikidata demo time July 17th
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links