Last modified: 2012-12-12 08:30:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44376, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42376 - puppet modules are not validated on submission
puppet modules are not validated on submission
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-23 09:07 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-12-12 08:30 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-11-23 09:07:03 UTC 
The Jenkins job in charge of validating puppet manifests only validate site.pp. It does include several manifests but will not load the one handled by puppet autoloader such as the modules.

We will have to run puppet parser validate on each .pp files under /modules/
Comment 1 Antoine "hashar" Musso (WMF) 2012-12-10 22:12:21 UTC 
I have a patch for it. Pending a bit more testing.
Comment 2 Antoine "hashar" Musso (WMF) 2012-12-11 14:04:35 UTC 
https://gerrit.wikimedia.org/r/#/c/38066/
Comment 3 Antoine "hashar" Musso (WMF) 2012-12-12 08:30:18 UTC 
Patch merged by Leslie. Works fine in production \O/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links