Last modified: 2013-05-21 07:52:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44377, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42377 - Jenkins: Set up validation for puppet templates
Jenkins: Set up validation for puppet templates
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-23 09:09 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-05-21 07:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-11-23 09:09:40 UTC 
Puppet makes extensive uses of ruby templates knowns as ERB. We are not currently checking their syntax in the puppet validation Jenkins job.

According to puppet documentation at http://docs.puppetlabs.com/guides/templating.html one could use:

 erb -P -x -T '-' mytemplate.erb | ruby -c
Comment 1 Gerrit Notification Bot 2013-04-25 15:06:05 UTC 
Related URL: https://gerrit.wikimedia.org/r/60856 (Gerrit Change I47e8c3b2fedbacdf26ade9a406bafe6f758d42f1)
Comment 2 Gerrit Notification Bot 2013-04-25 15:22:32 UTC 
Related URL: https://gerrit.wikimedia.org/r/60863 (Gerrit Change Icd6b32a48a3ce01f87aa3c19d6bf477affd56444)
Comment 3 Antoine "hashar" Musso (WMF) 2013-04-25 15:51:48 UTC 
I have deployed the ERB linter. It is only triggered when an ERB file is modified.

The test change is:

https://gerrit.wikimedia.org/r/60866

Patchset 1 has a faulty ERB.
Patchset 2 fix it
Patchset 3 does not have any ERB: no job is triggered.


The job is not going to block for now, will enable that after a few days.
Comment 4 Antoine "hashar" Musso (WMF) 2013-05-08 22:09:41 UTC 
The job failed when renaming an erb template https://gerrit.wikimedia.org/r/#/c/60945/
Comment 5 Antoine "hashar" Musso (WMF) 2013-05-21 07:52:43 UTC 
I cant reproduce the issue.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links