Last modified: 2012-11-27 22:48:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44400, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42400 - VisualEditor: Pass reference to data element to DM node constructor
VisualEditor: Pass reference to data element to DM node constructor
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2012-12-10
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-23 21:04 UTC by Roan Kattouw
Modified: 2012-11-27 22:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2012-11-23 21:04:05 UTC 
Post-December cleanup:

Rather than passing the type, length, attributes and (soon) annotations into the dm.Node constructors separately, we should just pass a reference to the data element. This will make a lot of things cleaner, and make the constructors more consistent between node types.
Comment 1 Roan Kattouw 2012-11-27 22:08:40 UTC 
https://gerrit.wikimedia.org/r/#/c/34956/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links