Last modified: 2013-11-21 14:41:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44404, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42404 - VisualEditor: Still get a pawn when select-all->replace in Firefox
VisualEditor: Still get a pawn when select-all->replace in Firefox
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2012-12-10
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-24 02:46 UTC by James Forrester
Modified: 2013-11-21 14:41 UTC (History)
5 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2012-11-24 02:46:26 UTC 
Go to demos/ve/?page=aliens in Firefox; select all:

  TypeError: end is undefined    ve.ce.Surface.js (line 980)

Press "a" (or backspace and then "a"):

  TypeError: start is undefined  ve.ce.Surface.js (line 995)
  
  (And a pawn appears in its own <p> above the a.)

On any click thereafter,

  TypeError: node is null        ve.ce.Surface.js (line 1073)
Comment 1 Trevor Parscal 2012-11-26 23:05:44 UTC 
I resolved this in Ia7347527e6466262e819f456404b32926fd95e34 by correcting the offsets before showing selection. This seems to work well so far, but really getNodeAndOffset is a nasty function that needs some love soon.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links