Last modified: 2014-11-10 11:46:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44433, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42433 - Cleanup PID code in Utils
Cleanup PID code in Utils
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-25 15:54 UTC by Jeroen De Dauw
Modified: 2014-11-10 11:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jeroen De Dauw 2012-11-25 15:54:48 UTC 
Currently (04e798e4deb50d31bd460ffe018df875b36a87c7) the Wikibasse\Utils class holds isPidAlive, getPidLock and makePidFilename methods, all public, static and without tests. Seems like these should go into their own object that then has associated unit tests.

This code is currently contributing a good bit to making the Utils class one of the, according to PHP CodeCoverage, highest risks in the project: http://wikidata-docs.wikimedia.de/testcoverage/phpcoverage/20121121/extensions_Wikibase.dashboard.html
Comment 1 Lydia Pintscher 2014-11-10 11:46:19 UTC 
Still relevant?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links