Last modified: 2012-12-14 13:47:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44475, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42475 - Hide anons and logged in users filters don't work with Wikidata changes
Hide anons and logged in users filters don't work with Wikidata changes
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jens Ohlig
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-27 11:58 UTC by Aude
Modified: 2012-12-14 13:47 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2012-11-27 11:58:09 UTC
Hide anonymous users | Hide logged-in users filters are incompatible with the Wikidata changes.

These filters depend on rc_user (id) in the recentchanges table.  It is set to 0 for anons and set to something other than 0 for logged in users.

For Wikimedia, an option would be to check central auth and assign the rc_user id accordingly if it's a linked account with Wikidata, and to 0 if the user was an IP on wikidata.  There's still the question of what id to assign non-linked users.

For external Wikibase Client installs, central auth obviously won't work and we need another way to do this.
Comment 1 Daniel Kinzler 2012-11-28 11:18:26 UTC
(In reply to comment #0)
> For Wikimedia, an option would be to check central auth and assign the rc_user
> id accordingly if it's a linked account with Wikidata, and to 0 if the user was
> an IP on wikidata.

What if the user was logged in on wikidata, but does not have an account on the local wiki? Then there is no user ID that can be used. I think that happens quite frequently, e.g. for people coming from en.wikipedia to wikidata - they won't have an account or user ID e.g. on fr.wikipedia.

Other things we could do:

* "anon" could be defined as User ID 0 AND change_type != external. That will then not filter external anons.

* Use user ID -1, not 0, when injecting wikidata changes. Might confuse other code though.

I can't think of a really good soltuion except for a separate rc_anon field in core.
Comment 2 jeblad 2012-12-05 10:48:43 UTC
Change I4b49a0c2: Hide anons and logged in users filters with Wikidata changes
Comment 3 abraham.taherivand 2012-12-10 20:44:13 UTC
Verified in Wikidata demo sprint 25
Comment 4 Anja Jentzsch 2012-12-14 13:47:01 UTC
Change I16eee28a: (bug 42475) follow up, make sure rc_user id gets set correctly and allow filter to work

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links