Last modified: 2013-05-10 11:37:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44479, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42479 - stall causes problems in IE when its callback returns something that's not a Deferred object
stall causes problems in IE when its callback returns something that's not a ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-27 16:53 UTC by Brad Jorsch
Modified: 2013-05-10 11:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2012-11-27 16:53:21 UTC
See [[en:Wikipedia:Village pump (technical)#Can't go directly to feedback pages]].

The 'stall' method installs an event handler that calls a callback which is expected to return a Deferred object, queues up a "re-fire the event" function for when that Deferred object resolves, and then returns false for the original event.

But if the callback returns something other than a Deferred object (e.g. as AFTv5 does if $.aftTrack.clickTrackingOn is false), returns an already-resolved Deferred object, or throws an exception, stall will try to re-fire the event before the original event handler returns. This causes problems in IE at least for the 'click' event, as the re-fired click is ignored.

Also, it seems if the Deferred object returned by the callback is rejected, stall will never re-fire the event since it only attaches a "done" handler and not a "fail" handler. I don't know whether or not this is intended behavior.
Comment 1 Matthias Mullie 2012-11-29 16:42:36 UTC
https://gerrit.wikimedia.org/r/#/c/35913/ should fix the issue of not being able to re-fire the event (at least for me it does); jquery's trigger seems more reliable

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links