Last modified: 2014-02-12 23:53:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44480, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42480 - Disabling desktop view is broken
Disabling desktop view is broken
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-27 17:33 UTC by Asher Feldman
Modified: 2014-02-12 23:53 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Asher Feldman 2012-11-27 17:33:21 UTC 
If a user on the mobile site using a normally redirected browser views an article in desktop mode, and then attempts to switch back to mobile with the link at the bottom of every page, they are still left with a cookie that bypasses the mobile redirect.  Any normal link to wikipedia takes them to the desktop site only. 

This has been tested on ios 5.1 and 6.0.1 devices.
Comment 1 Arthur Richards 2012-11-27 19:14:16 UTC 
Just confirmed with stock browser and chrome on Android 4.1.1, although I cannot replicate the problem in my iOS 6.0 simulator. Something must've gone amiss with the JS that unsets the cookie.
Comment 2 Arthur Richards 2012-11-27 19:35:54 UTC 
It looks like when the concept of ResourceLoader 'targets' was introduced, all RL modules in MobileFrontend were given a target of 'mobile' - which is incorrect for the JS that unsets the stopMobileRedirect cookie (it should only ever load on the desktop site). I suspect this is what is causing the issue. Fixed in https://gerrit.wikimedia.org/r/#/c/35422/
Comment 3 db [inactive,noenotif] 2012-11-28 13:31:02 UTC 
(In reply to comment #2)
> Fixed in https://gerrit.wikimedia.org/r/#/c/35422/

Status Merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links