Last modified: 2012-12-13 14:02:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44483, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42483 - Updater: Database serialization may cause problems, since the connection is not restored on wakeup.
Updater: Database serialization may cause problems, since the connection is n...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Mark A. Hershberger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-27 18:39 UTC by Sam Reed (reedy)
Modified: 2012-12-13 14:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-11-27 18:39:50 UTC
Upon running the updater after https://gerrit.wikimedia.org/r/#/c/13855/ was merged, I get:

Purging caches...done.
Database serialization may cause problems, since the connection is not restored on wakeup.
Backtrace:
#0 [internal function]: DatabaseBase->__sleep()
#1 /var/www/wiki/mediawiki/core/includes/installer/DatabaseUpdater.php(412): serialize(Array)
#2 /var/www/wiki/mediawiki/core/includes/installer/DatabaseUpdater.php(361): DatabaseUpdater->setAppliedUpdates('1.21alpha', Array)
#3 /var/www/wiki/mediawiki/core/maintenance/update.php(151): DatabaseUpdater->doUpdates(Array)
#4 /var/www/wiki/mediawiki/core/maintenance/doMaintenance.php(110): UpdateMediaWiki->execute()
#5 /var/www/wiki/mediawiki/core/maintenance/update.php(193): require_once('/var/www/wiki/m...')
#6 {main}
Comment 1 Aude 2012-11-29 17:07:44 UTC
We also get this on our Wikidata test setups, which have all the WMF deployed extensions enabled.  Specifically, the abuse filter is a problem.  If I disable Abuse Filter, all is good when running update.php  

If I enable it, I see the error.

There also is an issue with editing, with Abuse Filter enabled.

[Thu Nov 29 16:40:21 2012] [error] [client 93.220.88.64] PHP Fatal error:  Call to a member function setLBInfo() on a non-object in /var/www/common/php-master/includes/db/LoadBalancer.php on line 723, 

Although it doesn't seem to matter if I setup an external DB for abusefilter (like central auth, which works perfectly for me), and set the following settings:

    $wgAbuseFilterCentralDB = 'abusefilter';                                                        
    $wgAbuseFilterIsCentral = true;    

If I revert my core code to c4d0ce485280223eda024cc52d37ee19ade02111 (before  https://gerrit.wikimedia.org/r/#/c/13855/) then things work fine with update.php and AbuseFilter installed.
Comment 2 Sam Reed (reedy) 2012-11-29 17:25:56 UTC
(In reply to comment #1)
> We also get this on our Wikidata test setups, which have all the WMF deployed
> extensions enabled.  Specifically, the abuse filter is a problem.  If I disable
> Abuse Filter, all is good when running update.php  

Aha, thanks for narrowing it down.
Comment 3 Chad H. 2012-11-29 17:56:38 UTC
Backing it out in Gerrit change #35923.
Comment 4 DaSch 2012-12-02 23:04:14 UTC
+1
please force merging the gerrit change
thx
Comment 5 DaSch 2012-12-02 23:05:47 UTC
Is there maybe a connection to my bug #42637 ?
Comment 6 Brad Jorsch 2012-12-03 20:29:06 UTC
Gerrit change I96e6dffe should fix this.
Comment 7 Chad H. 2012-12-03 20:41:12 UTC
(In reply to comment #5)
> Is there maybe a connection to my bug #42637 ?

No, not at all.
Comment 8 Andre Klapper 2012-12-13 13:32:53 UTC
(In reply to comment #6)
> Gerrit change I96e6dffe should fix this.

It's merged. Can this be closed, or does the problem still happen?
Comment 9 Brad Jorsch 2012-12-13 14:02:41 UTC
Looks fixed to me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links