Last modified: 2012-12-09 17:20:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44494, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42494 - Don't run WRITE operations in ORMRowTest when testing on a Client instance
Don't run WRITE operations in ORMRowTest when testing on a Client instance
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: tobias.gritschacher
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-28 09:20 UTC by tobias.gritschacher
Modified: 2012-12-09 17:20 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2012-11-28 09:20:04 UTC
From E-Mail discussion:

Approach A:
"We could override the relevant test functions to skip the test if run on a
client setup. That detection could be implemented by defining a constant in
WikibaseClient.php (and a different constant in Wikibase.php). E.g. WB_CLIENT
and WB_REPO, or some such."

Approach B:
"Alternatively, split off the write tests from the read tests, and put the write
test into the repo extension. ORMRowTest could take a flag in the constructor,
telling it whether write operations should be tested."
Comment 1 tobias.gritschacher 2012-11-28 12:25:59 UTC
Going for approach A in https://gerrit.wikimedia.org/r/#/c/35610/
Comment 2 abraham.taherivand 2012-12-05 16:28:56 UTC
Verified in Wikidata demo sprint 25

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links