Last modified: 2014-03-18 17:05:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44593, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42593 - CodeEditor should use ContentHandler
CodeEditor should use ContentHandler
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-01 05:45 UTC by Ori Livneh
Modified: 2014-03-18 17:05 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2012-12-01 05:45:40 UTC
The code for this extension predates Daniel K.'s work on ContentHandler in core, and as a result its approach to content-types is archaic and ad-hoc. Rather than check the file extension and then give up, it should instead rely on the interface exposed by ContentHandler and ContentModel classes.
Comment 1 Gerrit Notification Bot 2013-12-31 10:21:45 UTC
Change 104721 had a related patch set uploaded by TheDJ:
ContentModel: Use CM to choose CE language

https://gerrit.wikimedia.org/r/104721
Comment 2 Derk-Jan Hartman 2013-12-31 10:22:20 UTC
Slightly related: CM for Scribunto https://bugzilla.wikimedia.org/59160
Comment 3 Gerrit Notification Bot 2014-01-10 15:43:44 UTC
Change 104721 merged by jenkins-bot:
Use page ContentModel to choose editor language

https://gerrit.wikimedia.org/r/104721
Comment 4 Andre Klapper 2014-03-11 17:14:21 UTC
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links