Last modified: 2012-12-03 23:26:17 UTC
While debugging a problem with uncommitted queries in a maintenance script I noticed that the /* $fname .. */ comments are not added to these queries. the Database::begin, Database::doBegin methods do pass it around, and callers also provide it. However Database::query messes up by relying on the presence of whitespace in the sql string: > $commentedSql = preg_replace( '/\s/', " /* $fname $userName */ ", $sql, 1 );
Change-Id: I48dc8b3f68a6764327b4b1a8f7c06c59a25a31bb
Landed in master.