Last modified: 2013-04-22 16:17:21 UTC
At some point display units stopped working for me, in the sense that ALL units of a quantity property is printed out. I have not been able to reproduce this on referata, but looking for the cause, I found an odd thing at line 180 in inincludes/datavalues/SMW_DV_Quantity.php It currently reads: if ( $di->getDIType() instanceof SMWDIBlob ) { ...but $di->getDIType will be an integer (3, if SMWDIBlob). I think it is supposed to be like this: if ( $di instanceof SMWDIBlob ) { Changing it like that makes display units work again, at least for me!
Yes, you are right and the winner for the first bug found after release. Will have a fix ready after the 1.9.x and 1.8.x branch have been swapped.
Yay! :)
https://gerrit.wikimedia.org/r/#/c/37182/1
Merged into 1.9.x and 1.8.x
Can you please assign the bugs you mark as ASSIGNED or FIXED? Clicking the "take" link adds just an extra second to your work, improves our workflow and avoids any chance to get pointless notifications like this one. :) Background & discussion: http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/064874.html - please follow-up there is you wish. Thank you!
