Last modified: 2012-12-05 20:32:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44707, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42707 - VisualEditor: Deleting across inline alien errors
VisualEditor: Deleting across inline alien errors
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2012-12-10
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-05 01:01 UTC by Christian Williams
Modified: 2012-12-05 20:32 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Williams 2012-12-05 01:01:11 UTC
Try creating "some text <inlinealien>blah</inlinealien> more text" and select across the inline alien and delete. 

Uncaught TypeError: Cannot call method 'getDataFromNode' of undefined
Comment 1 Roan Kattouw 2012-12-05 18:54:04 UTC
Argh. I figured out why this happens.

* .splice() is called on the dm.ParagraphNode to remove the alien
* which calls .adjustLength() on the dm.ParagraphNode
* which emits an update event on the dm.ParagraphNode
* which causes .renderContents() to be called on the ce.ParagraphNode
* which attempts to rerender its ce.TextNode children
* one of which is now associated with a detached dm.TextNode
* which means it crashed when trying to get the data from the linear model

I'm not entirely sure what the solution should be. Perhaps ce.ContentBranchNode shouldn't rerender for an update on the node itself, only on its children?
Comment 2 James Forrester 2012-12-05 20:14:22 UTC
Fix in Gerrit change #37056.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links