Last modified: 2012-12-07 21:37:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44806, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42806 - VisualEditor: Type mismatch when inserting unbalanced content
VisualEditor: Type mismatch when inserting unbalanced content
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2012-12-10
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-06 23:52 UTC by Christian Williams
Modified: 2012-12-07 21:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Williams 2012-12-06 23:52:37 UTC
Steps to reproduce:
1. Copy part of a headline and part of a following paragraph
2. Paste into a paragrah

The linmod being inserted will look something like this:
["s", "u", "m", "?", Object, Object, "C", "o", "n", "t"]

The objects are closing heading and opening paragraph.

The error is in ve.dm.Document.js on 1145.
Comment 1 James Forrester 2012-12-07 00:59:44 UTC
Now being done by Trevor; reassigning.
Comment 2 Trevor Parscal 2012-12-07 01:28:35 UTC
I0d2b593e05ebdee807e2cc6eeb902d542db3895f is a start, but there's still some issues.

Given the target: <p>12[cursor]34</p>

OK: ab</p><p>cd
OK: ab</h2><p>cd
BAD: ab</p></li><p>cd
Comment 3 Christian Williams 2012-12-07 18:08:52 UTC
ab</p></li><p>cd is invalid markup anyway.
Comment 4 James Forrester 2012-12-07 18:29:40 UTC
I believe Trevor meant ab</p></li></ol><p>cd breaking.
Comment 5 Trevor Parscal 2012-12-07 19:16:12 UTC
Id9269a29e51ca213508de8f155d3feec5e5b0774 should resolve this
Comment 6 James Forrester 2012-12-07 21:37:55 UTC
Now merged into master.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links