Last modified: 2012-12-18 00:40:08 UTC
Extension messages should be prefixed with the extension, so welcomesiteuser and welcomesiteuseranon should be prefixed with onboarding- Also welcomesiteuser should support GENDER for languages where it makes a difference to "Welcome, <user!>". But because we pass $user->getName(), as I understand https://www.mediawiki.org/wiki/Internationalisation#.E2.80.A6on_user_names_via_GENDER the information is available to localized messages, so there's nothing to do!
I've done all of this except changing gettingstarted to onboarding-gettingstarted. I wasn't able to get that to work. From https://www.mediawiki.org/wiki/Manual:Special_pages#Basic_special_page_template: "Generally the special page should be named after the extension: so the Gadgets extension has the file Gadgets.php and SpecialGadgets.php" Not following that has made things more complicated than they have to be. I recommend we rename the extension to GettingStarted. For the gender, it also says to make a note, which I did. I've done a gerrit with my progress so far (https://gerrit.wikimedia.org/r/#/c/37610/), but I would like to amend it with a full rename of the extension to GettingStarted (which implies Extension:GettingStarted, etc.).
I think renaming to GettingStarted is just fine.
Great. The Gerrit updated for this, and when merged will fix this bug. Next, we will need to rename the repo on the Gerrit server.
Seems dealt with?
