Last modified: 2013-01-02 11:49:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44866, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42866 - [Regression] Page "credits" show realnames instead of usernames after upgrading (deprecated $wgAllowRealNames=false was used)
[Regression] Page "credits" show realnames instead of usernames after upgradi...
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-08 19:15 UTC by T. Gries
Modified: 2013-01-02 11:49 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2012-12-08 19:15:36 UTC
after updating the core (git pull) I found that my wikis ( $wgMaxCredits = 4;) show realnames instead of usernames on bottom of wiki pages.

Has anyone an explanation for this effect, or is it a bug or regression ?

I checked
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=history;f=includes/actions/CreditsAction.php
but could not find something at the first glance.

observed on

* commit 7c6762ee2cf027f02ecc13bcecc89caa7b63e64e Date:   Sat Dec 8 15:08:46 2012 +0000
Comment 1 T. Gries 2012-12-08 19:25:55 UTC
bisect: 
this version was okay

* version 7d6d54d shows usernames (= okay)
* commit 7d6d54df8a068a982c3c8f2ae1d188f3383ca9c5
* Author: Reedy <reedy@wikimedia.org>
* Date:   Tue Jul 17 15:39:45 2012 +0000
Comment 2 T. Gries 2012-12-08 20:14:35 UTC
last version which shows usernames in the "credits" is (for me)

* commit 01e1b1a8e806ebd65b1ee157b0e555fe1a0641ef
* Author: daniel <daniel.kinzler@wikimedia.de>
* Date:   Fri Oct 5 16:50:32 2012 +0200

next versions fail:

i) either mediawiki not working
* PHP Fatal error:  Call to undefined method CreditsAction::getCredits() in /work/epw/srv/www/htdocs/epowiki/includes/SkinTemplate.php on line 339

ii) or realnames instead of usernames
Comment 3 T. Gries 2012-12-08 20:42:13 UTC
SOLVED.

When you use the deprecated $wgAllowRealName = false; this does not work any more since 1.21.0, wherein it is removed, and Credits are shown for Realnames.

You must use 

$wgHiddenPrefs[] = 'realname';

References:

* https://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs
* https://www.mediawiki.org/wiki/Manual:$wgAllowRealName
Comment 4 T. Gries 2012-12-13 21:48:36 UTC
When upgrading a wiki which still uses $wgAllowRealName = false (which is deprecated but was working since recently) it can lead to an unwanted disclosure of real names (for example used by Auth modules) in the "credits" section of pages.

A corresponding information should be added to the RELEASE NOTES or upgrade information.

Alternatively, an "emergency exit" could stop execution instead of revealing real names on wikis where this is not wanted or allowed.
Comment 5 T. Gries 2012-12-13 21:49:09 UTC
You have been warned.
Comment 6 db [inactive,noenotif] 2013-01-02 11:49:51 UTC
(In reply to comment #4)
> A corresponding information should be added to the
> RELEASE NOTES or upgrade
> information.

Already there:

=== Configuration changes in 1.21 ===
...
* Deprecated $wgAllowRealName is removed. Use $wgHiddenPrefs[] = 'realname'
  instead.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links