Last modified: 2012-12-12 15:29:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44927, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42927 - mwEmbed adds padding to all inputs in jQuery dialogs not just its own (CSS)
mwEmbed adds padding to all inputs in jQuery dialogs not just its own (CSS)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-10 22:11 UTC by Rainer Rillke @commons.wikimedia
Modified: 2012-12-12 15:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2012-12-10 22:11:16 UTC
Activation of mwEmbed at Wikimedia Commons leads to some bugs. Therefore, I call it a regression. Writing this bug report presumably took me more time than fixing the bug but if I don't get dev-access, it's not my problem.

mwEmbed adds padding to all inputs in jQuery dialogs not just its own.

Browsers: all.
OS: all.

Responsible CSS rule:

.ui-widget-content input {
    padding: 5px;
}

How to reproduce:
Go to
https://commons.wikimedia.org/wiki/Commons:Forum?useskin=vector&debug=true&withJS=MediaWiki:VisualFileChange.js
click right click the text-input and then "inspect" its applied CSS rules.

Source:
https://bits.wikimedia.org/static-1.21wmf5/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/EmbedPlayer.css

FixIt:
Add a custom class to your mw-embed dialogs and change the CSS-rule.
Comment 1 Jan Gerber 2012-12-12 15:29:47 UTC
merged in https://gerrit.wikimedia.org/r/#/c/38047/ will be fixed on site with next deployment

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links