Last modified: 2013-04-22 16:16:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44949, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42949 - ApiMain assumes MWException
ApiMain assumes MWException
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.21.x
All All
: High normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-11 13:47 UTC by Max Semenik
Modified: 2013-04-22 16:16 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2012-12-11 13:47:10 UTC
ApiMain.php, line 373:

} catch ( Exception $e ) {

line 380:

if ( $wgLogExceptionBacktrace ) {
	wfDebugLog( 'exception', $e->getLogMessage() . "\n" . $e->getTraceAsString() . "\n" );
} else {
	wfDebugLog( 'exception', $e->getLogMessage() );
}

Since getLogMessage() is defined MWException,  if Exception caught is not MWException (which is allowed by catch), we get a call to undefined method fatal.
Comment 1 Brad Jorsch 2012-12-11 14:16:03 UTC
Gerrit change #38074
Comment 2 Dereckson 2012-12-26 17:03:33 UTC
[ Bug assigned to code submitter ]
Comment 3 Alexandre Emsenhuber [IAlex] 2012-12-28 11:55:31 UTC
Change merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links