Last modified: 2013-01-16 16:18:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44982, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42982 - Blank page with only "Create an account" on post-login submission due to TitleBlacklist
Blank page with only "Create an account" on post-login submission due to Titl...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
E3 Experiments (Other open bugs)
master
All All
: High critical (vote)
: ---
Assigned To: spage
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-12 05:48 UTC by MZMcBride
Modified: 2013-01-16 16:18 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Before login submission (143.26 KB, image/png)
2012-12-12 05:48 UTC, MZMcBride
Details
After login submission (107.36 KB, image/png)
2012-12-12 05:49 UTC, MZMcBride
Details
Screenshot in Firefox 16 (236.23 KB, image/png)
2012-12-12 21:05 UTC, Steven Walling
Details

Description MZMcBride 2012-12-12 05:48:33 UTC
When I try to make an account on the English Wikipedia at <https://en.wikipedia.org/w/index.php?title=Special:UserLogin&type=signup&returnto=Main+Page>, it gives a strange error after I press the "Create account" button. It might be related to the username. I'm attaching two screenshots which should give steps to reproduce.
Comment 1 MZMcBride 2012-12-12 05:48:59 UTC
Created attachment 11491 [details]
Before login submission
Comment 2 MZMcBride 2012-12-12 05:49:53 UTC
Created attachment 11492 [details]
After login submission
Comment 3 Steven Walling 2012-12-12 20:57:53 UTC
@MZMcBride

Thanks for reporting. I'm going to try and reproduce it. In the meantime, just to confirm, you have JavaScript and cookies enabled in this browser? If you see this again, it would be a big help to check your browser console and report any errors you see.
Comment 4 Steven Walling 2012-12-12 21:05:23 UTC
Created attachment 11497 [details]
Screenshot in Firefox 16
Comment 5 Steven Walling 2012-12-12 21:06:43 UTC
Was able to reproduce with the same username ("Joining Wikipedia is free"), but using the same browser I was able to create User:WMFTest123456. Screenshot attached with console output.
Comment 6 Platonides 2012-12-12 21:08:36 UTC
I suspect the "Joining Wikipedia is free" has been blocked by TitleBlacklist.
Comment 7 Steven Walling 2012-12-12 21:17:08 UTC
Yes, when I try it with JS off (which gives you the old form), the TitleBlacklist prevents creation. I get the same blank error in the new version when trying any other name prevented by MediaWiki:Titleblacklist. 

We were aware that clientside validation in its current form doesn't play well with Extension:AntiSpoof and the TitleBlacklist, and might in a few cases incorrectly confirm as good a name which the server rejects. However, we need to make sure the server-generated error is correctly displayed to users, instead of this blank error. 

Thanks again for the help MZ and Platonides.
Comment 8 spage 2012-12-13 07:41:07 UTC
Thanks so much for tracking this down!  The JavaScript on enwiki that enhances account creation munges the first table it finds in the content div. Extension:Title Blacklist doesn't use  a table for its errors so our testing of this worked fine.  But on enwiki someone tweaked MediaWiki:Titleblacklist-forbidden-new-account message to use an {{fmbox}} which puts it in a table.  So the first table is not the login form, result: JS errors and garbled HTML.

Things to do:
1.  Avoid this specific JS error that halts the munging leaving the form invisible.
2.  Be smarter about finding the right table to modify.
3.  Don't hide so much of the page during munging so if JS fails the user sees something.
4.  Even if errors munging, always show the hidden part.

Gerrit change #42982 does 1-3.  4 is dubious, since partly successful jQuery-fu may be worse than failing.
Comment 9 spage 2012-12-13 07:42:17 UTC
Sorry, I mean Gerrit change #38494
Comment 10 spage 2012-12-14 21:28:28 UTC
Fix merged to enwiki, seems to work now.  (Though https://en.wikipedia.org/wiki/Special:Version still shows old extension version.)
Comment 11 Steven Walling 2012-12-14 22:05:16 UTC
Tested with the 'Joining Wikipedia is free' username, and all appears well.
Comment 12 Matthew Flaschen 2013-01-15 18:35:45 UTC
Stein Van Uytven indicated that he encountered similar symptoms on another wiki.  I'm CCing him so he can provide further details.
Comment 13 Platonides 2013-01-15 21:57:54 UTC
If he saw a similar symptom on another wiki (not using the account creation enhancement), it should be reported as a new bug.
Comment 14 Matthew Flaschen 2013-01-15 22:00:11 UTC
He was using E3Experiments.
Comment 15 MZMcBride 2013-01-16 01:10:43 UTC
(In reply to comment #14)
> He was using E3Experiments.

I suppose the question then becomes whether he was using a version of the extension that includes <https://gerrit.wikimedia.org/r/38494>.
Comment 16 svu1911 2013-01-16 07:45:29 UTC
(In reply to comment #15)
> (In reply to comment #14)
> > He was using E3Experiments.
> 
> I suppose the question then becomes whether he was using a version of the
> extension that includes <https://gerrit.wikimedia.org/r/38494>.

Hi,

I am using http://www.mediawiki.org/wiki/Extension:ArticleFeedbackv5
When I installed this extension it required a few other extensions including E3Experiments.

After installing it all, when I tried "create user" it returned a blank page. 
(If I was logged in I could create a user via special pages)

When I commented out "require_once( "$IP/extensions/E3Experiments/Experiments.php" );" in LocalSettings.php the "create user" functioned again so I presumed it was a problem with the E3Experiments extension.

At the time of the bug I was using :	E3Experiments-master-8d34938.tar.gz	(version 0.7.1)

I've also tested the patched : experiments/acux/accountCreationUX.js file but the problem persists.

Thanks to S Page who pointed me in this direction I noticed a console error "$.trackActionWithOptions is not a function".
This seems to have something to do with another needed extension : "ClickTracking"

This bug in Clicktracking is referred to here :

http://www.mail-archive.com/wikibugs-l@lists.wikimedia.org/msg160795.html
http://www.gossamer-threads.com/lists/wiki/mediawiki-cvs/298490

And a patch is posted here :

https://gerrit.wikimedia.org/r/#/c/24078/

I've just tried to replace both files :

./extensions/ClickTracking/ClickTracking.hooks.php
./extensions/ClickTracking/modules/jquery.clickTracking.js

After trying to create a user when not logged in it seems to all work fine now with E2Experiments enabled in LocalSettings.php.

Thanks all for helping out!
Comment 17 svu1911 2013-01-16 07:51:11 UTC
*E3Experiments

:)
Comment 18 Platonides 2013-01-16 16:18:25 UTC
> I suppose the question then becomes whether he was using a version of the
> extension that includes <https://gerrit.wikimedia.org/r/38494>.

He wasn't. 8d34938 is actually the parent of that change.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links