Last modified: 2014-01-07 09:34:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44992, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42992 - Optimize TermSqlCache::saveTermsOfEntity to only update the table if actually neccessary
Optimize TermSqlCache::saveTermsOfEntity to only update the table if actually...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
backlog, termsearch
: performance
Depends on:
Blocks: 44529
  Show dependency tree / graph
 
Reported: 2012-12-12 10:36 UTC by Daniel Kinzler
Modified: 2014-01-07 09:34 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-12-12 10:36:15 UTC 
Currently, TermSqlCache::saveTermsOfEntity will detect whether the entity's terms are different from the ones stored in the database for the entity's ID. If there is any change, it will delete all terms for the entity, and re-save all terms.

Instead, it would be nice to just delete the terms that were since removed from, and add just the ones that got added to the entity.
Comment 1 Daniel Kinzler 2013-10-29 11:34:09 UTC 
Bumping prio - implementing this is pretty simple, and it would reduce database load quite a bit.
Comment 2 Daniel Kinzler 2013-11-29 15:23:19 UTC 
bumping some more
Comment 3 Gerrit Notification Bot 2013-12-04 19:20:00 UTC 
Change 99187 had a related patch set uploaded by Daniel Kinzler:
(bug 42992) reduce churn on wb_terms table.

https://gerrit.wikimedia.org/r/99187
Comment 4 Gerrit Notification Bot 2013-12-05 14:27:47 UTC 
Change 99187 merged by Jeroen De Dauw:
(bug 42992) reduce churn on wb_terms table.

https://gerrit.wikimedia.org/r/99187
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links