Last modified: 2013-07-04 10:38:29 UTC
If you have a comment inserted on its own line within a table, it seems to break parsing of the table. See https://en.wikipedia.org/wiki/User:Kaldari/EditorTest for an example.
Parsoid bug, see http://parsoid.wmflabs.org/en/User:Kaldari/EditorTest
Minimal test case: echo -e '{|\n|foo\n<!-- -->\n|}\nfoo' | nodejs parse --wt2wt {| |foo <!-- --> <nowiki>|} foo</nowiki>
This is not a serialization issue. This is a parse problem: [subbu@earth tests] echo -e '{|\n|foo\n<\!-- -->\n|}\nfoo' | node parse.js <p data-parsoid="{"dsr":[1,6]}">-e {|</p> foo <!-- --> <p data-parsoid="{"dsr":[20,26]}">|} foo</p>
> This is not a serialization issue. This is a parse problem: > > [subbu@earth tests] echo -e '{|\n|foo\n<\!-- -->\n|}\nfoo' | node parse.js > <p data-parsoid="{"dsr":[1,6]}">-e {|</p> > foo > <!-- --> > <p data-parsoid="{"dsr":[20,26]}">|} > foo</p> Sorry, bad commandline. The right output is this here: [subbu@earth tests] echo '{|\n|foo\n<\!-- -->\n|}\nfoo' | node parse.js <table data-parsoid="{"tsr":[0,2],"autoInsertedEnd":true,"dsr":[0,24]}"> <tbody data-parsoid="{"dsr":[3,24]}"><tr data-parsoid="{"dsr":[3,24]}"><td data-parsoid="{"tsr":[3,4],"autoInsertedEnd":true,"dsr":[3,24]}">foo <!-- --> <p data-parsoid="{"dsr":[17,23]}">|} foo</p> </td></tr></tbody></table>
He- that's why I had changed the title back. The table cell content eats one newline too much after the comment, which prevents the table end tag from matching. Am working on a fix.
Fix committed in https://gerrit.wikimedia.org/r/#/c/38484/.
That was fast :)
Merged.
[Parsoid component reorg by merging CPP/* tickets into General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
