Last modified: 2013-01-07 21:34:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45051, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43051 - VisualEditor: Suggestion tool fails to close when escaping out of context menu.
VisualEditor: Suggestion tool fails to close when escaping out of context menu.
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2013-01-02
Assigned To: Rob Moen
:
: 43055 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-13 00:31 UTC by Rob Moen
Modified: 2013-01-07 21:34 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Moen 2012-12-13 00:31:05 UTC
Pressing escape while editing a link with the suggestion tool open causes the context menu to close without ever hiding the suggestion tool in the dom.
Comment 1 Rob Moen 2012-12-13 00:56:23 UTC
Escape was normally handled by calling onInput, until yesterday I simplified the close logic.  This slipped through the cracks pre-release.

Patched in https://gerrit.wikimedia.org/r/38468
Comment 2 Rob Moen 2012-12-13 19:05:28 UTC
*** Bug 43055 has been marked as a duplicate of this bug. ***
Comment 3 James Forrester 2013-01-07 21:34:30 UTC
Add to deployment milestone.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links