Last modified: 2013-04-22 16:14:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45056, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43056 - VisualEditor: Things are sometimes alienated as block when they should be inline
VisualEditor: Things are sometimes alienated as block when they should be inline
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2013-01-16
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-13 08:11 UTC by Raimond Spekking
Modified: 2013-04-22 16:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2012-12-13 08:11:40 UTC
"phantoms" text is wrapped into a "div class="ve-ce-phantoms" " which adds a linebreak because div is a  block element, see https://en.wikipedia.org/wiki/User:Raymond/nowiki

Better to use a span I think.
Comment 1 Roan Kattouw 2012-12-13 08:56:46 UTC
Fixing summary. Editable nodes are called "aliens". The "phantom" is the green hatched-out overlay that appears when mousing over an alien. It's an absolutely positioned <div> that exists outside of the main editor DOM. Because of the mouseover effect, you can't actually inspect the aliens themselves easily, but when you do, you'll find that the actual uneditable content is in <div class="ve-ce-alienBlock"> or <span class="ve-ce-alienInline"> as appropriate.

The issue here is that some things (nowikis in Raymond's example, and I've seen some references do it in the wild) are alienated as alienBlock nodes by ve.dm.Converter when they should really be alienInline nodes.
Comment 2 Roan Kattouw 2012-12-22 11:18:27 UTC
https://gerrit.wikimedia.org/r/39846
Comment 3 James Forrester 2013-01-08 20:58:16 UTC
Merged; code will be deployed as part of the 2013-01-16 release cycle.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links