Last modified: 2012-12-14 01:13:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45077, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43077 - CategoryTree git/master does not work with mw 1.20.2 branch
CategoryTree git/master does not work with mw 1.20.2 branch
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CategoryTree (Other open bugs)
REL1_20-branch
All All
: Immediate critical (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-13 15:51 UTC by Gregor Hagedorn
Modified: 2012-12-14 01:13 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gregor Hagedorn 2012-12-13 15:51:59 UTC
We fail to get CategoryTree to work with mw 1.20 and see no documentation that a specific older version should be used.

Failing: http://biowikifarm.net/test_v20/Category_Test - this should look like
http://biowikifarm.net/test/Category_Test (the latter still under 1.18.x)

See here for other installed extensions: http://biowikifarm.net/test_v20/Special:Version

This seems to be related to the discussion 
http://www.mediawiki.org/wiki/Extension_talk:CategoryTree#no_categories.21_20941
where others seem to have similar problems with mediawiki version later than 1.18.
Comment 1 Asaf Bartov 2012-12-13 19:55:04 UTC
For an example on a WMF wiki, see https://meta.wikimedia.org/wiki/Grants:Index/Requests
(if you do see categories, purge, and they'll disappear).
Comment 2 Rob Lanphier 2012-12-13 20:05:05 UTC
Investigating now
Comment 3 Rob Lanphier 2012-12-13 20:11:34 UTC
This may be a simple matter of reverting Gerrit change #34493 and Gerrit change #36750 .  Since these were both Reedy's change, and since that's the only thing that changed in CategoryTree, that seems like a good place to start.
Comment 4 Sam Reed (reedy) 2012-12-13 20:36:06 UTC
I think it's much more likely just to be boolean fail:

	-»       »       if ( $title === null || $title === '' || $title === false ) {
878	+»       »       if ( strval( $title ) !== '' ) {
Comment 5 Sam Reed (reedy) 2012-12-13 20:37:21 UTC
https://gerrit.wikimedia.org/r/38613
Comment 6 Chris Steipp 2012-12-14 01:13:32 UTC
Deployed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links