Last modified: 2013-06-12 22:35:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45094, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43094 - Parsoid: References should be wrapped in a <sup>, not a <span>
Parsoid: References should be wrapped in a <sup>, not a <span>
Status: RESOLVED WONTFIX
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low trivial
: ---
Assigned To: Gabriel Wicke
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-13 21:20 UTC by James Forrester
Modified: 2013-06-12 22:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2012-12-13 21:20:24 UTC
Canonical HTML (from PHP parser):

<sup id="cite_ref-Forty_47-0" class="reference">
  <a href="#cite_note-Forty-47"><span>[</span>47<span>]</span></a>
</sup>

Output from Parsoid:

<span id="cite_ref-Forty-46-0" class="reference" about="#mwt408" typeof="mw:Object/Ext/Cite" data-parsoid="…">
  <a href="#cite_note-Forty-46">[47]</a>
</span>

I have no idea if the inner spans have any value, but the outer span should be a sup element instead.

(Also, the names of the cites are indexed from 0 in names but 1 in label - 46 vs. 47, whereas in PHP parser they're indexed from 1 in both; not sure if this is a problem.)
Comment 1 Bartosz Dziewoński 2012-12-13 22:05:35 UTC
The inner spans come from https://en.wikipedia.org/w/index.php?title=MediaWiki:Cite_reference_link&action=edit .
Comment 2 Gabriel Wicke 2013-06-12 22:35:13 UTC
About sup and sub in the HTML5 spec: 

"These elements must be used only to mark up typographical conventions with specific meanings, not for typographical presentation for presentation's sake. For example, it would be inappropriate for the sub and sup elements to be used in the name of the LaTeX document preparation system. In general, authors should use these elements only if the absence of those elements would change the meaning of the content."

This does not seem to be the case here, and styling is more flexible with spans. Since we will require some CSS adjustments anyway we might as well clean this one up too.

Closing as WONTFIX for that reason.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links