Last modified: 2012-12-16 22:19:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45098, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43098 - VisualEditor: Elements nested inside Aliens with z-index appear on top of the zebra pattern
VisualEditor: Elements nested inside Aliens with z-index appear on top of the...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-01-02
Assigned To: Krinkle
http://en.wikipedia.org/wiki/Buri_Ram...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-13 23:38 UTC by Mark Holmquist
Modified: 2012-12-16 22:19 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2012-12-13 23:38:50 UTC
Try editing the page [[:en:Buri_Ram_Airport]] with VisualEditor. Mouse over the infobox. There's an element that sticks above the alien marking, because it has a z-index attribute.

I don't know how best to fix this, I assume it would be bad to simply set z-index=1000 and be on your way, but it's an inconsistent appearance and something to be fixed eventually.

I suspect this may also be a good beginner bug, so if someone from the VE team can mark this as easy, then we can leave it for a newcomer.
Comment 1 Mark Holmquist 2012-12-13 23:39:33 UTC
Sorry, setting web browser in case it matters.
Comment 2 Krinkle 2012-12-13 23:46:16 UTC
The following CSS rule exists:

> .ve-ce-alienBlockNode, .ve-ce-alienInlineNode,
> .ve-ce-alienBlockNode *, .ve-ce-alienInlineNode * {
>   position: relative !important;
>   top: 0 !important;
>   left: 0 !important;
>   bottom: 0 !important;
>   right: 0 !important;
> }

They have position relative, so the z-index within is relative and constraint within the alien.

However that isn't the case. This is because the top node (alienBlockNode, not alienBlockNode *) needs z-index: 0; to complete this feature. It is the combination of z-index: 0; and position: relative; that makes it work.

It was presumably forgotten because it needs to be on a separate rule (not inside the one above, since that would set z-index: 0; on all blocks, thus destroying the order of elements within the alien).
Comment 3 Rob Moen 2012-12-14 00:56:37 UTC
Patch in https://gerrit.wikimedia.org/r/38669
Comment 4 Mark Holmquist 2012-12-14 20:10:57 UTC
You guys have no concept of leaving a simple bug for new contributors? :)

Not to worry, I'll go find more. Thanks Rob!
Comment 5 Krinkle 2012-12-16 22:19:49 UTC
Change-Id: I889074a659483ce3d48380be5f50f80abb573286

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links