Last modified: 2012-12-14 21:03:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45131, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43131 - Searching by commenter is slow
Searching by commenter is slow
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Daniel Zahn
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-14 17:34 UTC by Andre Klapper
Modified: 2012-12-14 21:03 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andre Klapper 2012-12-14 17:34:44 UTC
Apply the one-liner patch at http://bzr.mozilla.org/bugzilla/4.2/revision/8176 to fix https://bugzilla.mozilla.org/show_bug.cgi?id=818007

After this has been done, the corresponding file in https://gerrit.wikimedia.org/r/gitweb?p=wikimedia%2Fbugzilla%2Fmodifications.git;a=summary needs to be updated too.
Comment 1 Andre Klapper 2012-12-14 17:39:14 UTC
https://rt.wikimedia.org/Ticket/Display.html?id=4122
Comment 2 Daniel Zahn 2012-12-14 18:57:30 UTC
the patch as linked above just adds the DISTINCT keyword to a SELECT from the database on search. 

per https://bugzilla.mozilla.org/show_bug.cgi?id=818007 this improves search performance like this:

---
David Lawrence [:dkl] 2012-12-04 14:07:59 PST

Although not a massive improvement as others have reported, it does improve things somewhat on my test install of BMO 4.2

with DISTINCT:
1.89s
1.94s
1.89s
----
1.90s average

without DISTINCT:
2.07s
2.09s
2.10s
-----
2.08s average
---

I added the DISTINCT in Bugzilla/Search.pm on kaulen.
Comment 3 Daniel Zahn 2012-12-14 20:29:25 UTC
and added a .gitreview file to the BZ modifications repo so that "git review" should now work

and added the patched Search.pm file in the 4.2 directory

https://gerrit.wikimedia.org/r/#/c/38751/
Comment 4 Andre Klapper 2012-12-14 21:03:29 UTC
Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links