Last modified: 2013-02-04 21:45:00 UTC
At the end of the test.js tour, there is a "Launch a Tour on using Tours" button, but it fails silently.
I believe this is because it's simply not defined on the test wiki, piramido.wmflabs.org?
It's also not in master. I'm going to file a separate bug about the need to copy the starter tours manually to MediaWiki.
There are a few separate issues here. Every time guided tour fails, it does it silently for the user, but logs for various anticipated failure types (including this one). That seems reasonable to me, but it could fling alerts about if louder javascript error handling is the norm. The failure is because there is not a second tour defined for it to link to. I'd rather not solve it by deleting the linking button as that sample tour is essentially the documentation on how to write tours, so the features it shows off are the ones people will likely copy to their own real tours. A better fix for this bug would be to write a second tour for it to link to. IMHO the code is fine in this instance, the problem is a content shortage.
There is a second tour here about the gadget version: https://github.com/tychay/mwgadget.GuidedTour/blob/master/tours/guidedtour.js But it is short and does not really apply to the extension version, so may not be a useful starting point.
We should either edit the test tour to remove mention of the second test tour, or simply add it as well. I'm fine with either. The exact content of the examples doesn't really matter, as long as it accurately reflects the technical capabilities of the extension.
Luke is right. The 'silently' is not the issue. It is using the best-practice mw.log, which means I should have run it in debug mode to see the issues. I'll make a 'makeatour' tour for this.
Seems like we've decided to abandon this idea? http://lists.wikimedia.org/pipermail/ee/2013-February/000133.html
Yes, at least for now. As a note, the gadget guidedtour (https://github.com/tychay/mwgadget.GuidedTour/blob/master/tours/guidedtour.js) was really a guide to using tours, not to developing them.
