Last modified: 2014-04-17 20:22:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45179, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43179 - Separate link class for anonymous users
Separate link class for anonymous users
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.23.0
All All
: Low enhancement (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-16 22:28 UTC by Steve
Modified: 2014-04-17 20:22 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steve 2012-12-16 22:28:36 UTC
Right now on Recent changes, links for logged-in users and IP's use the same "mw-userlink" class:

<a class="mw-userlink" title="User:USER123" href="/User:USER123">USER123</a>
<a class="mw-userlink" title="Special:Contributions/12.34.567.89" href="Special:Contributions/12.34.567.89">12.34.567.89</a>

I'm proposing that we give IP's a separate link class so that I can use CSS to make the IP's a different color to stand-out. This would make patrolling edits on Recent changes easier for me and my admins. Something like:

<a class="mw-userlink" title="User:USER123" href="/User:USER123">USER123</a>
<a class="mw-anonlink" title="Special:Contributions/12.34.567.89" href="Special:Contributions/12.34.567.89">12.34.567.89</a>
Comment 1 Dereckson 2012-12-23 18:07:06 UTC
[ Taking this bug. ]

To maximize coherence, this enhancement should be implemented to the following special pages:
- [[Special:Contributions]]
- [[Special:DeletedContributions]]
- [[Special:RecentChanges]]
- [[Special:Watchlist]]

It's also to be implemented on pages history.

To avoid to break any stuff relying on current CSS class, the CSS class for anonymous users should be added and not replaced:

<a class="mw-userlink" title="User:USER123" href="/User:USER123">USER123</a>
<a class="mw-userlink mw-anonuserlink" title="Special:Contributions/12.34.567.89"
href="Special:Contributions/12.34.567.89">12.34.567.89</a>

Would that be acceptable?
Comment 2 Steve 2012-12-23 18:16:45 UTC
Yes, that makes sense.
Comment 3 Andre Klapper 2013-03-20 15:45:59 UTC
(In reply to comment #1 by Dereckson)
> [ Taking this bug. ]

Dereckson: Do you still plan to work on this?

Note: As this has the 1.21.0 target milestone set, this needs to receive a patch. If this does not receive a patch in the next weeks, the Target Milestone will likely get removed.
Comment 4 Andre Klapper 2013-04-09 20:02:46 UTC
Dereckson: Do you still plan to work on this?
Comment 5 Technical 13 2014-02-23 23:09:50 UTC
Is anyone still working on this?  This would make it much easier than the current methods I've been using if($('.mw-userlink').search(/[12]?[\d]{1,2}\.[12]?[\d]{1,2}\.[12]?[\d]{1,2}\.[12]?[\d]{1,2}(\/[1-3]?[\d])?/)){ isIP=true; } which of course only catches IPv4 addresses.
Comment 6 Gerrit Notification Bot 2014-02-24 00:25:31 UTC
Change 115095 had a related patch set uploaded by Legoktm:
Add 'mw-anonuserlink' class for anonymous users

https://gerrit.wikimedia.org/r/115095
Comment 7 Gerrit Notification Bot 2014-04-17 20:21:35 UTC
Change 115095 merged by jenkins-bot:
Add 'mw-anonuserlink' class for anonymous users

https://gerrit.wikimedia.org/r/115095

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links